Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752335AbdHIJvp (ORCPT ); Wed, 9 Aug 2017 05:51:45 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:45181 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbdHIJvn (ORCPT ); Wed, 9 Aug 2017 05:51:43 -0400 X-ME-Sender: X-Sasl-enc: H69LP9+oJ3o8cowbahkFCjXmvC2FvNhRf8tkiV38e8up 1502272301 Subject: Re: [PATCH 1/3] autofs - fix AT_NO_AUTOMOUNT not being honored To: David Howells Cc: Andrew Morton , autofs mailing list , Ondrej Holy , Colin Walters , Kernel Mailing List , linux-fsdevel References: <150216641255.11652.4204561328197919771.stgit@pluto.themaw.net> <4689.1502267949@warthog.procyon.org.uk> From: Ian Kent Message-ID: Date: Wed, 9 Aug 2017 17:51:17 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <4689.1502267949@warthog.procyon.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 473 Lines: 15 On 09/08/17 16:39, David Howells wrote: > Ian Kent wrote: > >> In order to handle the AT_NO_AUTOMOUNT for both system calls the >> negative dentry case in follow_automount() needs to be changed to >> return ENOENT when the LOOKUP_AUTOMOUNT flag is clear (and the other >> required flags are clear). > > Should the be EREMOTE instead of ENOENT? I thought about that and ended up thinking ENOENT was more sensible but I'll look at it again. Thanks Ian