Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752257AbdHIKpv (ORCPT ); Wed, 9 Aug 2017 06:45:51 -0400 Received: from mail-qt0-f169.google.com ([209.85.216.169]:38493 "EHLO mail-qt0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884AbdHIKpu (ORCPT ); Wed, 9 Aug 2017 06:45:50 -0400 MIME-Version: 1.0 In-Reply-To: <1502220499-18351-1-git-send-email-khoroshilov@ispras.ru> References: <20170807215943.GA22433@electric-eye.fr.zoreil.com> <1502220499-18351-1-git-send-email-khoroshilov@ispras.ru> From: Andy Shevchenko Date: Wed, 9 Aug 2017 13:45:48 +0300 Message-ID: Subject: Re: [PATCH net-next v2] wan: dscc4: add checks for dma mapping errors To: Alexey Khoroshilov Cc: Francois Romieu , "David S . Miller" , netdev , "linux-kernel@vger.kernel.org" , ldv-project@linuxtesting.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 468 Lines: 15 On Tue, Aug 8, 2017 at 10:28 PM, Alexey Khoroshilov wrote: > The driver does not check if mapping dma memory succeed. > The patch adds the checks and failure handling. > > Found by Linux Driver Verification project (linuxtesting.org). Since it is going to be v3, just to mention that IIRC we better not to use PCI DMA mapping API in favour of generic DMA mapping API. Can you please double check this? -- With Best Regards, Andy Shevchenko