Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752142AbdHIMgJ (ORCPT ); Wed, 9 Aug 2017 08:36:09 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38672 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbdHIMgI (ORCPT ); Wed, 9 Aug 2017 08:36:08 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0E715600C7 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH] drm/bridge: make drm_bridge_funcs const To: Laurent Pinchart , Bhumika Goyal Cc: julia.lawall@lip6.fr, a.hajda@samsung.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1502207650-20029-1-git-send-email-bhumirks@gmail.com> <2177679.cxpq8VCtMS@avalon> From: Archit Taneja Message-ID: <3d207993-195d-cef8-1aac-c0534a525bf5@codeaurora.org> Date: Wed, 9 Aug 2017 18:06:02 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <2177679.cxpq8VCtMS@avalon> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2094 Lines: 60 On 08/08/2017 09:33 PM, Laurent Pinchart wrote: > Hi Bhumika, > > Thank you for the patch. > > On Tuesday 08 Aug 2017 21:24:10 Bhumika Goyal wrote: >> Make these structures const as they are only stored in the funcs field >> of drm_bridge structure, which is of type const. >> Done using Coccinelle. >> >> Signed-off-by: Bhumika Goyal > > Reviewed-by: Laurent Pinchart queued to drm-misc-next Thanks, Archit > >> --- >> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +- >> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c >> b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ee16635..58b4fb2 >> 100644 >> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c >> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c >> @@ -857,7 +857,7 @@ static int adv7511_bridge_attach(struct drm_bridge >> *bridge) return ret; >> } >> >> -static struct drm_bridge_funcs adv7511_bridge_funcs = { >> +static const struct drm_bridge_funcs adv7511_bridge_funcs = { >> .enable = adv7511_bridge_enable, >> .disable = adv7511_bridge_disable, >> .mode_set = adv7511_bridge_mode_set, >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c >> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 36f5ccb..63c7a01 >> 100644 >> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c >> @@ -811,7 +811,7 @@ static int dw_mipi_dsi_bridge_attach(struct drm_bridge >> *bridge) return drm_bridge_attach(bridge->encoder, dsi->panel_bridge, >> bridge); } >> >> -static struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = { >> +static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = { >> .mode_set = dw_mipi_dsi_bridge_mode_set, >> .enable = dw_mipi_dsi_bridge_enable, >> .post_disable = dw_mipi_dsi_bridge_post_disable, > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project