Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752716AbdHIMga (ORCPT ); Wed, 9 Aug 2017 08:36:30 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38806 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbdHIMg3 (ORCPT ); Wed, 9 Aug 2017 08:36:29 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6F348600EC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH] drm: bridge: dw-hdmi: constify snd_pcm_ops structures To: Laurent Pinchart , Arvind Yadav Cc: a.hajda@samsung.com, airlied@linux.ie, elfring@users.sourceforge.net, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <44c0ccab8b5658d17a3ed553e721136b53d95521.1502264156.git.arvind.yadav.cs@gmail.com> <2774445.RGyCgtBS77@avalon> From: Archit Taneja Message-ID: Date: Wed, 9 Aug 2017 18:06:24 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <2774445.RGyCgtBS77@avalon> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1409 Lines: 46 On 08/09/2017 02:08 PM, Laurent Pinchart wrote: > Hi Arvind, > > Thank you for the patch. > > On Wednesday 09 Aug 2017 13:08:37 Arvind Yadav wrote: >> snd_pcm_ops are not supposed to change at runtime. All functions >> working with snd_pcm_ops provided by work with >> const snd_pcm_ops. So mark the non-const structs as const. >> >> Signed-off-by: Arvind Yadav > > Reviewed-by: Laurent Pinchart queued to drm-misc-next Thanks, Archit > >> --- >> drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c >> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c index >> 8f2d137..cf3f0ca 100644 >> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c >> @@ -517,7 +517,7 @@ static snd_pcm_uframes_t dw_hdmi_pointer(struct >> snd_pcm_substream *substream) return bytes_to_frames(runtime, >> dw->buf_offset); >> } >> >> -static struct snd_pcm_ops snd_dw_hdmi_ops = { >> +static const struct snd_pcm_ops snd_dw_hdmi_ops = { >> .open = dw_hdmi_open, >> .close = dw_hdmi_close, >> .ioctl = snd_pcm_lib_ioctl, > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project