Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752754AbdHINqe (ORCPT ); Wed, 9 Aug 2017 09:46:34 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:58379 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752459AbdHINqd (ORCPT ); Wed, 9 Aug 2017 09:46:33 -0400 Date: Wed, 9 Aug 2017 15:45:50 +0200 From: Andrew Lunn To: John Crispin Cc: Vivien Didelot , Florian Fainelli , "David S . Miller" , Sean Wang , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Muciri Gatimu , Shashidhar Lakkavalli Subject: Re: [PATCH 1/4] net-next: dsa: move struct dsa_device_ops to the global header file Message-ID: <20170809134550.GC30723@lunn.ch> References: <20170809124119.24320-1-john@phrozen.org> <20170809124119.24320-2-john@phrozen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170809124119.24320-2-john@phrozen.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 530 Lines: 16 On Wed, Aug 09, 2017 at 02:41:16PM +0200, John Crispin wrote: > We need to access this struct from within the flow_dissector to fix > dissection for packets coming in on DSA devices. > > Signed-off-by: Muciri Gatimu > Signed-off-by: Shashidhar Lakkavalli > Signed-off-by: John Crispin Hi John Please add the Reviewed-by: tags you receive from previous versions. It makes it easier for reviewers to see what actually needs reviewing. Thanks Andrew