Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752814AbdHINsL (ORCPT <rfc822;w@1wt.eu>);
        Wed, 9 Aug 2017 09:48:11 -0400
Received: from mail-qt0-f196.google.com ([209.85.216.196]:38501 "EHLO
        mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752459AbdHINsJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 9 Aug 2017 09:48:09 -0400
MIME-Version: 1.0
In-Reply-To: <20170808231306.GH29372@obsidianresearch.com>
References: <20170806164428.2273-1-mikko.rapeli@iki.fi> <20170806164428.2273-31-mikko.rapeli@iki.fi>
 <20170808231306.GH29372@obsidianresearch.com>
From: Moni Shoua <monis@mellanox.com>
Date: Wed, 9 Aug 2017 16:48:08 +0300
X-Google-Sender-Auth: Gd7mWAmvPn7XfwRR9rMdZThC2ME
Message-ID: <CAG9sBKP=NuSJzhg8rMBTsTuZkfzPDjxYgAGjiCnEMe=9xXB0xA@mail.gmail.com>
Subject: Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Mikko Rapeli <mikko.rapeli@iki.fi>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
        linux-api@vger.kernel.org, Sean Hefty <sean.hefty@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>,
        linux-rdma <linux-rdma@vger.kernel.org>,
        Doug Ledford <dledford@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 248
Lines: 7

>
> I'm not sure this is a good idea, linux/in.h should not be included in
> userspace users of this file, 'sockaddr_in' needs to come from glibc's
> 'netinet/in.h' instead..
>
> Jason
Is it wrong to include include/uapi/linux/in.h from userspace?