Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752696AbdHINzo (ORCPT ); Wed, 9 Aug 2017 09:55:44 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:58409 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752678AbdHINzn (ORCPT ); Wed, 9 Aug 2017 09:55:43 -0400 Date: Wed, 9 Aug 2017 15:55:08 +0200 From: Andrew Lunn To: John Crispin Cc: Vivien Didelot , Florian Fainelli , "David S . Miller" , Sean Wang , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Muciri Gatimu , Shashidhar Lakkavalli Subject: Re: [PATCH 4/4] net-next: dsa: fix flow dissection Message-ID: <20170809135508.GF30723@lunn.ch> References: <20170809124119.24320-1-john@phrozen.org> <20170809124119.24320-5-john@phrozen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170809124119.24320-5-john@phrozen.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 827 Lines: 17 On Wed, Aug 09, 2017 at 02:41:19PM +0200, John Crispin wrote: > RPS and probably other kernel features are currently broken on some if not > all DSA devices. The root cause of this is that skb_hash will call the > flow_dissector. At this point the skb still contains the magic switch > header and the skb->protocol field is not set up to the correct 802.3 > value yet. By the time the tag specific code is called, removing the header > and properly setting the protocol an invalid hash is already set. In the > case of the mt7530 this will result in all flows always having the same > hash. > > Signed-off-by: Muciri Gatimu > Signed-off-by: Shashidhar Lakkavalli > Signed-off-by: John Crispin Reviewed-by: Andrew Lunn Andrew