Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753311AbdHIO4z (ORCPT <rfc822;w@1wt.eu>);
        Wed, 9 Aug 2017 10:56:55 -0400
Received: from vps0.lunn.ch ([178.209.37.122]:58491 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752718AbdHIO4y (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 9 Aug 2017 10:56:54 -0400
Date: Wed, 9 Aug 2017 16:56:51 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Romain Perier <romain.perier@collabora.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: Use the right logging function in
 stmmac_mdio_register
Message-ID: <20170809145651.GK30723@lunn.ch>
References: <20170809144019.17975-1-romain.perier@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170809144019.17975-1-romain.perier@collabora.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 456
Lines: 15

On Wed, Aug 09, 2017 at 04:40:19PM +0200, Romain Perier wrote:
> @@ -285,14 +286,14 @@ int stmmac_mdio_register(struct net_device *ndev)
>  			irq_str = irq_num;
>  			break;
>  		}
> -		netdev_info(ndev, "PHY ID %08x at %d IRQ %s (%s)%s\n",
> +		dev_info(dev, "PHY ID %08x at %d IRQ %s (%s)%s\n",
>  			    phydev->phy_id, addr, irq_str, phydev_name(phydev),
>  			    act ? " active" : "");

Hi Romain

phy_attached_print() would be better.

     Andrew