Subject: Re: [PATCH] net: stmmac: Use the right logging function in
 stmmac_mdio_register
To: Andrew Lunn <andrew@lunn.ch>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20170809144019.17975-1-romain.perier@collabora.com>
 <20170809145651.GK30723@lunn.ch>
From: Romain Perier <romain.perier@collabora.com>
Message-ID: <9067382c-412f-343e-8273-4464366ba0f2@collabora.com>
Date: Wed, 9 Aug 2017 16:58:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170809145651.GK30723@lunn.ch>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 616
Lines: 22

Hi Andrew,


Le 09/08/2017 à 16:56, Andrew Lunn a écrit :
> On Wed, Aug 09, 2017 at 04:40:19PM +0200, Romain Perier wrote:
>> @@ -285,14 +286,14 @@ int stmmac_mdio_register(struct net_device *ndev)
>>  			irq_str = irq_num;
>>  			break;
>>  		}
>> -		netdev_info(ndev, "PHY ID %08x at %d IRQ %s (%s)%s\n",
>> +		dev_info(dev, "PHY ID %08x at %d IRQ %s (%s)%s\n",
>>  			    phydev->phy_id, addr, irq_str, phydev_name(phydev),
>>  			    act ? " active" : "");
> Hi Romain
>
> phy_attached_print() would be better.
>
>      Andrew
Ok, I did not know this function, good to know. I will investigate

Thanks,
Romain