Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752697AbdHIPAx (ORCPT ); Wed, 9 Aug 2017 11:00:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43328 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751919AbdHIPAw (ORCPT ); Wed, 9 Aug 2017 11:00:52 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 57A1B28899E Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Wed, 9 Aug 2017 17:00:49 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: lkml , Ingo Molnar , Peter Zijlstra , Namhyung Kim , David Ahern , Thomas Richter Subject: Re: [PATCH 15/15] perf tests attr: Fix task term values Message-ID: <20170809150049.GA1244@krava> References: <20170703145030.12903-1-jolsa@kernel.org> <20170703145030.12903-16-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170703145030.12903-16-jolsa@kernel.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 09 Aug 2017 15:00:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2203 Lines: 71 On Mon, Jul 03, 2017 at 04:50:30PM +0200, Jiri Olsa wrote: > The perf_event_attr::task is 1 by default for first (tracking) > event in the session. Setting task=1 as default and adding > task=0 for cases that need it. hm, looks like this one was overlooked.. thanks, jirka > > Link: http://lkml.kernel.org/n/tip-w4uuxbwcrf8cjjjbko3ujs95@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/tests/attr/base-record | 2 +- > tools/perf/tests/attr/test-record-group | 1 + > tools/perf/tests/attr/test-record-group-sampling | 2 +- > tools/perf/tests/attr/test-record-group1 | 1 + > 4 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/tests/attr/base-record b/tools/perf/tests/attr/base-record > index 31e0b1da830b..37940665f736 100644 > --- a/tools/perf/tests/attr/base-record > +++ b/tools/perf/tests/attr/base-record > @@ -23,7 +23,7 @@ comm=1 > freq=1 > inherit_stat=0 > enable_on_exec=1 > -task=0 > +task=1 > watermark=0 > precise_ip=0|1|2|3 > mmap_data=0 > diff --git a/tools/perf/tests/attr/test-record-group b/tools/perf/tests/attr/test-record-group > index 6e7961f6f7a5..618ba1c17474 100644 > --- a/tools/perf/tests/attr/test-record-group > +++ b/tools/perf/tests/attr/test-record-group > @@ -17,5 +17,6 @@ sample_type=327 > read_format=4 > mmap=0 > comm=0 > +task=0 > enable_on_exec=0 > disabled=0 > diff --git a/tools/perf/tests/attr/test-record-group-sampling b/tools/perf/tests/attr/test-record-group-sampling > index ef59afd6d635..f906b793196f 100644 > --- a/tools/perf/tests/attr/test-record-group-sampling > +++ b/tools/perf/tests/attr/test-record-group-sampling > @@ -23,7 +23,7 @@ sample_type=343 > > # PERF_FORMAT_ID | PERF_FORMAT_GROUP > read_format=12 > - > +task=0 > mmap=0 > comm=0 > enable_on_exec=0 > diff --git a/tools/perf/tests/attr/test-record-group1 b/tools/perf/tests/attr/test-record-group1 > index 87a222d014d8..48e8bd12fe46 100644 > --- a/tools/perf/tests/attr/test-record-group1 > +++ b/tools/perf/tests/attr/test-record-group1 > @@ -18,5 +18,6 @@ sample_type=327 > read_format=4 > mmap=0 > comm=0 > +task=0 > enable_on_exec=0 > disabled=0 > -- > 2.9.4 >