Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbdHIPKe (ORCPT ); Wed, 9 Aug 2017 11:10:34 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:41646 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751977AbdHIPKd (ORCPT ); Wed, 9 Aug 2017 11:10:33 -0400 From: Vivien Didelot To: John Crispin , Andrew Lunn , Florian Fainelli , "David S . Miller" , Sean Wang Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Muciri Gatimu , Shashidhar Lakkavalli , John Crispin Subject: Re: [PATCH 0/4] net-next: dsa: fix flow dissection In-Reply-To: <20170809124119.24320-1-john@phrozen.org> References: <20170809124119.24320-1-john@phrozen.org> Date: Wed, 09 Aug 2017 11:07:28 -0400 Message-ID: <87h8xghj9r.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1391 Lines: 38 Hi John, John Crispin writes: > RPS and probably other kernel features are currently broken on some if not > all DSA devices. The root cause of this is that skb_hash will call the > flow_dissector. At this point the skb still contains the magic switch > header and the skb->protocol field is not set up to the correct 802.3 > value yet. By the time the tag specific code is called, removing the header > and properly setting the protocol an invalid hash is already set. In the > case of the mt7530 this will result in all flows always having the same > hash. > > Changes since RFC: > * use a callback instead of static values > * add cover letter > > John Crispin (4): > net-next: dsa: move struct dsa_device_ops to the global header file > net-next: dsa: add flow_dissect callback to struct dsa_device_ops > net-next: tag_mtk: add flow_dissect callback to the ops struct > net-next: dsa: fix flow dissection The "net-next" tag goes into the subject-prefix, i.e. "[PATCH net-next v3 0/4]" (this is the result of git format-patch --subject-prefix="PATCH net-next" -v3 --cover-letter.) The commit title prefix represents the most impacted subsystem, here "net: dsa: xxx" would map the net/dsa/ or drivers/net/dsa directories. Other than that, the whole patchset LGTM: Reviewed-by: Vivien Didelot Thanks, Vivien