Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753095AbdHIPO7 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 9 Aug 2017 11:14:59 -0400
Received: from mail-wm0-f68.google.com ([74.125.82.68]:36275 "EHLO
        mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751927AbdHIPO6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 9 Aug 2017 11:14:58 -0400
Date: Wed, 9 Aug 2017 17:14:46 +0200
From: Daniel Vetter <daniel@ffwll.ch>
To: Peter Rosin <peda@axentia.se>
Cc: Daniel Vetter <daniel.vetter@intel.com>, devel@driverdev.osuosl.org,
        Boris Brezillon <boris.brezillon@free-electrons.com>,
        vbox-dev@virtualbox.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Hans de Goede <hdegoede@redhat.com>,
        Michael Thayer <michael.thayer@oracle.com>
Subject: Re: [RESEND PATCH] staging: vboxvideo: remove dead gamma lut code
Message-ID: <20170809151446.wdwd62mcilhu4luy@phenom.ffwll.local>
Mail-Followup-To: Peter Rosin <peda@axentia.se>,
        Daniel Vetter <daniel.vetter@intel.com>, devel@driverdev.osuosl.org,
        Boris Brezillon <boris.brezillon@free-electrons.com>,
        vbox-dev@virtualbox.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Hans de Goede <hdegoede@redhat.com>,
        Michael Thayer <michael.thayer@oracle.com>
References: <20170804103034.2342-1-peda@axentia.se>
 <20170804104506.2414-1-peda@axentia.se>
 <20170807092127.6z7zkkiarfnkffsy@phenom.ffwll.local>
 <465d54cf-8e39-7a6e-d5a5-3a4751266f52@axentia.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <465d54cf-8e39-7a6e-d5a5-3a4751266f52@axentia.se>
X-Operating-System: Linux phenom 4.11.0-2-amd64 
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1627
Lines: 41

On Tue, Aug 08, 2017 at 01:54:52PM +0200, Peter Rosin wrote:
> On 2017-08-07 11:21, Daniel Vetter wrote:
> > On Fri, Aug 04, 2017 at 12:45:06PM +0200, Peter Rosin wrote:
> >> The redundant fb helpers .load_lut, .gamma_set and .gamma_get are
> >> no longer used. Remove the dead code that was not doing anything
> >> sensible anyway.
> >>
> >> Signed-off-by: Peter Rosin <peda@axentia.se>
> >> ---
> >>  drivers/staging/vboxvideo/vbox_fb.c   | 15 ---------------
> >>  drivers/staging/vboxvideo/vbox_mode.c |  5 -----
> >>  2 files changed, 20 deletions(-)
> >>
> >> [This time with an improved Cc list, sorry for the noise. For new
> >>  people, please refer to https://lkml.org/lkml/2017/7/13/593 for
> >>  context]
> >>
> >> Hi Daniel,
> >>
> >> Here it goes, but do you really need me to resend v5 14/14?
> > 
> > Well it's not yet on dri-devel, but our pre-merge CI bots can't read such
> > instructions. They expect a clean new series that applies cleanly, as a
> > top-post, when resending stuff.
> 
> Ok, noted for the next time. These things seem to vary from subsystem to
> subsystem, so it's not trivial to get it right w/o investing serious time
> looking things up. Anyway, sorry about the trouble.

Yes I know, the kernel is absolutely terrible with minor differences in
process between subsystems. And then getting sternly reprimanded if you
don't know them all :-(

Unfortunately our CI has the same problem, it can't parse all the
different flavours of how people re-submit patches, so we just had to
standardize on something.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch