Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753352AbdHIQkR (ORCPT ); Wed, 9 Aug 2017 12:40:17 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36480 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752439AbdHIQkP (ORCPT ); Wed, 9 Aug 2017 12:40:15 -0400 Date: Wed, 9 Aug 2017 18:40:10 +0200 From: Daniel Vetter To: Bhumika Goyal Cc: julia.lawall@lip6.fr, airlied@linux.ie, kraxel@redhat.com, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/virtio: make drm_fb_helper_funcs const Message-ID: <20170809164010.sff3ebprwpqv6axu@phenom.ffwll.local> Mail-Followup-To: Bhumika Goyal , julia.lawall@lip6.fr, airlied@linux.ie, kraxel@redhat.com, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <1502205245-17365-1-git-send-email-bhumirks@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502205245-17365-1-git-send-email-bhumirks@gmail.com> X-Operating-System: Linux phenom 4.11.0-2-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1702 Lines: 70 On Tue, Aug 08, 2017 at 08:44:05PM +0530, Bhumika Goyal wrote: > Make these structures const as they are only passed to the function > drm_fb_helper_prepare and the corresponding argument is of type const. > Done using Coccinelle > > @match disable optional_qualifier@ > identifier s; > @@ > static struct drm_fb_helper_funcs s = {...}; > > @ref@ > position p; > identifier match.s; > @@ > s@p > > @good1@ > identifier match.s; > expression e1,e2; > position ref.p; > @@ > drm_fb_helper_prepare(e1,e2,&s@p,...) > > @bad depends on !good1@ > position ref.p; > identifier match.s; > @@ > s@p > > @depends on forall !bad disable optional_qualifier@ > identifier match.s; > @@ > static > + const > struct drm_fb_helper_funcs s; > > Signed-off-by: Bhumika Goyal This and the previous one merged too. -Daniel > --- > drivers/gpu/drm/virtio/virtgpu_fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_fb.c b/drivers/gpu/drm/virtio/virtgpu_fb.c > index 046e28b..15d18fd 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_fb.c > +++ b/drivers/gpu/drm/virtio/virtgpu_fb.c > @@ -308,7 +308,7 @@ static int virtio_gpu_fbdev_destroy(struct drm_device *dev, > > return 0; > } > -static struct drm_fb_helper_funcs virtio_gpu_fb_helper_funcs = { > +static const struct drm_fb_helper_funcs virtio_gpu_fb_helper_funcs = { > .fb_probe = virtio_gpufb_create, > }; > > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch