Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752257AbdHIRgS (ORCPT ); Wed, 9 Aug 2017 13:36:18 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:38039 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751995AbdHIRgR (ORCPT ); Wed, 9 Aug 2017 13:36:17 -0400 Date: Wed, 9 Aug 2017 19:36:11 +0200 From: Daniel Vetter To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, Stefan Wahren , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/vc4: Fix leak of HDMI EDID Message-ID: <20170809173611.ept6f7gbuivxrzje@phenom.ffwll.local> Mail-Followup-To: Eric Anholt , dri-devel@lists.freedesktop.org, Stefan Wahren , linux-kernel@vger.kernel.org References: <20170808205605.4432-1-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170808205605.4432-1-eric@anholt.net> X-Operating-System: Linux phenom 4.11.0-2-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1236 Lines: 37 On Tue, Aug 08, 2017 at 01:56:05PM -0700, Eric Anholt wrote: > We don't keep a pointer to it around anywhere, so it's our job to free > it. > > Cc: Stefan Wahren > Link: https://github.com/anholt/linux/issues/101 > Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.") > Signed-off-by: Eric Anholt Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c > index ff09b8e2f9ee..937da8dd65b8 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -288,6 +288,7 @@ static int vc4_hdmi_connector_get_modes(struct drm_connector *connector) > drm_mode_connector_update_edid_property(connector, edid); > ret = drm_add_edid_modes(connector, edid); > drm_edid_to_eld(connector, edid); > + kfree(edid); > > return ret; > } > -- > 2.13.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch