Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752023AbdHIT3n (ORCPT ); Wed, 9 Aug 2017 15:29:43 -0400 Received: from mx2.suse.de ([195.135.220.15]:34429 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751602AbdHIT3m (ORCPT ); Wed, 9 Aug 2017 15:29:42 -0400 Date: Wed, 9 Aug 2017 21:29:40 +0200 From: "Luis R. Rodriguez" To: Daniel Mentz Cc: linux-kernel@vger.kernel.org, "Luis R . Rodriguez" , Greg Kroah-Hartman , Andrew Morton Subject: Re: [PATCH] kmod: test_kmod: Correctly lock reg_dev_mutex Message-ID: <20170809192940.GI27873@wotan.suse.de> References: <20170808232733.28415-1-danielmentz@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170808232733.28415-1-danielmentz@google.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 831 Lines: 25 On Tue, Aug 08, 2017 at 04:27:33PM -0700, Daniel Mentz wrote: > It appears that, in the preamble of register_test_dev_kmod(), > mutex_lock() has been confused with mutex_unlock(). > > Previously, register_test_dev_kmod() never called mutex_lock() but > instead, it called mutex_unlock() twice. > > Signed-off-by: Daniel Mentz > Cc: Luis R. Rodriguez > Cc: Greg Kroah-Hartman > Cc: Andrew Morton > --- Thanks Daniel but someone beat you to the fix, I've sent this to Andrew and he's integrated into his -mm tree. See: http://lkml.kernel.org/r/20170802211450.27928-5-mcgrof@kernel.org This series had other fixes: https://marc.info/?l=linux-kernel&m=150170850624962&w=2 I'll CC you on other kmod / test_kmod changes. Luis