Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752228AbdHIVFs (ORCPT ); Wed, 9 Aug 2017 17:05:48 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:37522 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751974AbdHIVFq (ORCPT ); Wed, 9 Aug 2017 17:05:46 -0400 MIME-Version: 1.0 In-Reply-To: <1502295823-20824-3-git-send-email-arvind.yadav.cs@gmail.com> References: <1502295823-20824-1-git-send-email-arvind.yadav.cs@gmail.com> <1502295823-20824-3-git-send-email-arvind.yadav.cs@gmail.com> From: Steve deRosier Date: Wed, 9 Aug 2017 14:05:45 -0700 Message-ID: Subject: Re: [PATCH v2 02/20] ath6kl: constify usb_device_id To: Arvind Yadav Cc: kvalo@codeaurora.org, petkan@nucleusys.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1278 Lines: 36 On Wed, Aug 9, 2017 at 9:23 AM, Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > changes in v2: > Re-submitting wireless separately. > > drivers/net/wireless/ath/ath6kl/usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c > index 9da3594..4defb7a 100644 > --- a/drivers/net/wireless/ath/ath6kl/usb.c > +++ b/drivers/net/wireless/ath/ath6kl/usb.c > @@ -1201,7 +1201,7 @@ static int ath6kl_usb_pm_resume(struct usb_interface *interface) > #endif > > /* table of devices that work with this driver */ > -static struct usb_device_id ath6kl_usb_ids[] = { > +static const struct usb_device_id ath6kl_usb_ids[] = { > {USB_DEVICE(0x0cf3, 0x9375)}, > {USB_DEVICE(0x0cf3, 0x9374)}, > { /* Terminating entry */ }, > -- > 2.7.4 > Looks good. Also builds and works properly. Reviewed-by: Steve deRosier Tested-by: Steve deRosier - Steve