Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752464AbdHIVub (ORCPT ); Wed, 9 Aug 2017 17:50:31 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55654 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbdHIVu3 (ORCPT ); Wed, 9 Aug 2017 17:50:29 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 63410601D2 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: Specify dload address for msm8916 and msm8996 To: Bjorn Andersson , Andy Gross , David Brown Cc: Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org References: <20170809201033.4967-1-bjorn.andersson@linaro.org> <20170809201033.4967-4-bjorn.andersson@linaro.org> From: Stephen Boyd Message-ID: <6a652887-5075-d406-2b9e-ebb77edeeb31@codeaurora.org> Date: Wed, 9 Aug 2017 14:50:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170809201033.4967-4-bjorn.andersson@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1862 Lines: 63 On 08/09/2017 01:10 PM, Bjorn Andersson wrote: > On msm8916 and msm8996 boards a secure io-write is used to write the > magic for selecting "download mode", specify this address in the > DeviceTree. > > Note that qcom_scm.download_mode=1 must be specified on the kernel > command line for the kernel to attempt selecting download mode. > > Signed-off-by: Bjorn Andersson > --- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 ++ > arch/arm64/boot/dts/qcom/msm8996.dtsi | 7 +++++++ > 2 files changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index 039991f80831..b7197f2e7209 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -241,6 +241,8 @@ > clocks = <&gcc GCC_CRYPTO_CLK>, <&gcc GCC_CRYPTO_AXI_CLK>, <&gcc GCC_CRYPTO_AHB_CLK>; > clock-names = "core", "bus", "iface"; > #reset-cells = <1>; > + > + qcom,dload-mode = <&tcsr>; > }; > }; > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 8f085716e258..2eee6a33f22b 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -261,6 +261,8 @@ > firmware { > scm { > compatible = "qcom,scm-msm8996"; > + > + qcom,dload-mode = <&tcsr>; We don't need an offset into tcsr? > }; > }; > > @@ -287,6 +289,11 @@ > reg = <0x740000 0x20000>; > }; > > + tcsr: syscon@1937000 { This doesn't match reg property. > + compatible = "qcom,tcsr-msm8996", "syscon"; > + reg = <0x7a0000 0x18000>; > + }; > + > intc: interrupt-controller@9bc0000 { > compatible = "arm,gic-v3"; > #interrupt-cells = <3>; -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project