Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752381AbdHIV4z (ORCPT ); Wed, 9 Aug 2017 17:56:55 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:34272 "EHLO mail-io0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752342AbdHIV4y (ORCPT ); Wed, 9 Aug 2017 17:56:54 -0400 MIME-Version: 1.0 In-Reply-To: <20170809192940.GI27873@wotan.suse.de> References: <20170808232733.28415-1-danielmentz@google.com> <20170809192940.GI27873@wotan.suse.de> From: Daniel Mentz Date: Wed, 9 Aug 2017 14:56:52 -0700 Message-ID: Subject: Re: [PATCH] kmod: test_kmod: Correctly lock reg_dev_mutex To: "Luis R. Rodriguez" Cc: lkml , Greg Kroah-Hartman , Andrew Morton Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 296 Lines: 8 OK. While we're here: I think there's a spelling error in usage() in tools/testing/selftests/kmod/kmod.sh echo " -c Run test ID once" echo " -s Run test ID x test-count number of times" I believe that "-c" and "-s" are swapped. "c" probably stands for count and "s" for single.