Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752298AbdHJCrw (ORCPT ); Wed, 9 Aug 2017 22:47:52 -0400 Received: from vmicros1.altlinux.org ([194.107.17.57]:35624 "EHLO vmicros1.altlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752095AbdHJCru (ORCPT ); Wed, 9 Aug 2017 22:47:50 -0400 Date: Thu, 10 Aug 2017 05:47:48 +0300 From: "Dmitry V. Levin" To: Jason Gunthorpe Cc: Moni Shoua , Mikko Rapeli , Linux Kernel Mailinglist , linux-api@vger.kernel.org, Sean Hefty , Hal Rosenstock , linux-rdma , Doug Ledford Subject: Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h Message-ID: <20170810024747.GA30198@altlinux.org> References: <20170806164428.2273-1-mikko.rapeli@iki.fi> <20170806164428.2273-31-mikko.rapeli@iki.fi> <20170808231306.GH29372@obsidianresearch.com> <20170809155241.GB15586@obsidianresearch.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zhXaljGHf11kAtnf" Content-Disposition: inline In-Reply-To: <20170809155241.GB15586@obsidianresearch.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1747 Lines: 47 --zhXaljGHf11kAtnf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 09, 2017 at 09:52:41AM -0600, Jason Gunthorpe wrote: > On Wed, Aug 09, 2017 at 04:48:08PM +0300, Moni Shoua wrote: > > > > > > I'm not sure this is a good idea, linux/in.h should not be included in > > > userspace users of this file, 'sockaddr_in' needs to come from glibc's > > > 'netinet/in.h' instead.. >=20 > > Is it wrong to include include/uapi/linux/in.h from userspace? >=20 > Generally speaking userspace should always use the glibc version of > the headers and not headers from under linux/ Sorry? Isn't the main idea of UAPI in providing the Linux interface for userspace, unlike glibc headers that provide other more or less standard interfaces like GNU, POSIX, etc? --=20 ldv --zhXaljGHf11kAtnf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJZi8lTAAoJEAVFT+BVnCUI/iMP/jm3ybCNJ7qYpb5FbRwBjKjZ vXV7Ki83gh3vSDuh/5CJiO8NYMFHB7Zw3y80nGSsKswKeaRKFkx+GO4pO4N5UcE0 r5Y1ULAW37HCvmY0bwX2hqP9+X8txvwuggoEH9u+A9EGSvYzs9SEF44+UG5z1MBJ 34svqjkk/y6ui5YRIqaIQQ9zFkQZZnBJnqDvOGFXHlBADOwn17qRHnbiRqLRw6JZ DzTep2uOEAuDOVTKwM7pyHILxz94Qf+OW7YYZYzi26SJvAExTD6qiZ273Hv5R9nS gKa5Pb6aB/85RkzbuDrxKQL1ww0MBGVdJm3SVhC1sxiCQt6HdmcEsFAvsN1HUyXt roHMj4LYtz+1iQTn8neRQYVI56t4gR9CspYnLXYMwX/6v/UtR9dixx6HghxsyQbp FhRZxJMUUz+xCSlpRdVNUvJ3bqwta92etTSMtV7dso+pQ72Bo1mgUFMkbjuyXdAT yFyTMDzOgQpLL1c67CCdE4uA8gdtJvOwaJQrNGlNAuJs+aGa54h4d6lY6gLNwW4J rHde+XVFg4Yd8bEqOafQlETNBIdfFQBCMMr0/lMY75hvEcHSpnGclTjaPuAETJoX LTzEQTZOINTAIpu0mIBe7rh9GWLjcN4AF9c2G+3xQe2h15cYlEp3WIK0xCxUgZ7w g0jNVagGvPnuwob0VJUh =4gVf -----END PGP SIGNATURE----- --zhXaljGHf11kAtnf--