Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752260AbdHJDKW (ORCPT ); Wed, 9 Aug 2017 23:10:22 -0400 Received: from gateway20.websitewelcome.com ([192.185.53.25]:37904 "EHLO gateway20.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752094AbdHJDKV (ORCPT ); Wed, 9 Aug 2017 23:10:21 -0400 X-Greylist: delayed 1500 seconds by postgrey-1.27 at vger.kernel.org; Wed, 09 Aug 2017 23:10:21 EDT Subject: Re: [PATCH] usb: gadget: udc: renesas_usb3: fix error return code in renesas_usb3_probe() To: Yoshihiro Shimoda , Felipe Balbi , Greg Kroah-Hartman References: <20170808223445.GA7163@embeddedgus> Cc: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: "Gustavo A. R. Silva" Message-ID: <7f1d6b30-de9b-88dc-648d-fbe13bd0027d@embeddedor.com> Date: Wed, 9 Aug 2017 21:23:22 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.192.74.87 X-Exim-ID: 1dfd8B-002EdT-Tp X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.65]) [187.192.74.87]:58280 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2033 Lines: 71 Hi Yoshihiro, On 08/09/2017 06:44 AM, Yoshihiro Shimoda wrote: > Hi Gustavo, > > Thank you for the patch! > I'm glad to help :) >> -----Original Message----- >> From: Gustavo A. R. Silva >> Sent: Wednesday, August 9, 2017 7:35 AM >> >> platform_get_irq() returns an error code, but the renesas_usb3 driver >> ignores it and always returns -ENODEV. This is not correct and, >> prevents -EPROBE_DEFER from being propagated properly. > > Thank you for the point. I got it. > >> Also, notice that platform_get_irq() no longer returns 0 on error: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92 >> af > > I don't think this explanation needs. > After this is removed, > > Acked-by: Yoshihiro Shimoda > Thank you -- Gustavo A. R. Silva > Best regards, > Yoshihiro Shimoda > >> Print error message and propagate the return value of platform_get_irq >> on failure. >> >> This issue was detected with the help of Coccinelle. >> >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/usb/gadget/udc/renesas_usb3.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c >> index e1de8fe..616d053 100644 >> --- a/drivers/usb/gadget/udc/renesas_usb3.c >> +++ b/drivers/usb/gadget/udc/renesas_usb3.c >> @@ -2468,8 +2468,10 @@ static int renesas_usb3_probe(struct platform_device *pdev) >> priv = match->data; >> >> irq = platform_get_irq(pdev, 0); >> - if (irq < 0) >> - return -ENODEV; >> + if (irq < 0) { >> + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq); >> + return irq; >> + } >> >> usb3 = devm_kzalloc(&pdev->dev, sizeof(*usb3), GFP_KERNEL); >> if (!usb3) >> -- >> 2.5.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html