Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752218AbdHJF37 (ORCPT ); Thu, 10 Aug 2017 01:29:59 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:35457 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751485AbdHJF36 (ORCPT ); Thu, 10 Aug 2017 01:29:58 -0400 MIME-Version: 1.0 In-Reply-To: <99a298c1-6241-f835-9587-31c526126453@ozlabs.org> References: <20170808035301.1980-1-brendanhiggins@google.com> <20170808035301.1980-5-brendanhiggins@google.com> <99a298c1-6241-f835-9587-31c526126453@ozlabs.org> From: Brendan Higgins Date: Wed, 9 Aug 2017 22:29:57 -0700 Message-ID: Subject: Re: [RFC v1 4/4] ipmi_bmc: bt-aspeed: port driver to IPMI BMC framework To: Jeremy Kerr Cc: Corey Minyard , Benjamin Fair , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Joel Stanley , Andrew Jeffery , openipmi-developer@lists.sourceforge.net, OpenBMC Maillist , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 736 Lines: 23 On Wed, Aug 9, 2017 at 7:31 PM, Jeremy Kerr wrote: > Hi Brendan, > >> The driver was handling interaction with userspace on its own. This >> patch changes it to use the functionality of the ipmi_bmc framework >> instead. >> >> Note that this removes the ability for the BMC to set SMS_ATN by making >> an ioctl. If this functionality is required, it can be added back in >> with a later patch. > > As Chris has mentioned, we do use this actively at the moment, so I'd > prefer if we could not drop the support for SMS_ATN. However, using a > different interface should be fine, if that helps. Whoops, I did not realize that anyone was using it. Yeah, adding it back in should not be too hard. > > Cheers, > > > Jeremy