Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752231AbdHJHHt (ORCPT ); Thu, 10 Aug 2017 03:07:49 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:40634 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbdHJHHr (ORCPT ); Thu, 10 Aug 2017 03:07:47 -0400 Date: Thu, 10 Aug 2017 09:07:34 +0200 From: Thomas Richter To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , lkml , Ingo Molnar , Peter Zijlstra , Namhyung Kim , David Ahern Subject: Re: [PATCH 15/15] perf tests attr: Fix task term values References: <20170703145030.12903-1-jolsa@kernel.org> <20170703145030.12903-16-jolsa@kernel.org> <20170809150049.GA1244@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170809150049.GA1244@krava> User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-GCONF: 00 x-cbid: 17081007-0016-0000-0000-000004E254D8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17081007-0017-0000-0000-0000281ACD89 Message-Id: <20170810070734.GB16932@oc2666213455.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-10_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1708100116 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2556 Lines: 79 On Wed, Aug 09, 2017 at 05:00:49PM +0200, Jiri Olsa wrote: > On Mon, Jul 03, 2017 at 04:50:30PM +0200, Jiri Olsa wrote: > > The perf_event_attr::task is 1 by default for first (tracking) > > event in the session. Setting task=1 as default and adding > > task=0 for cases that need it. > > hm, looks like this one was overlooked.. > > thanks, > jirka > > I have pull perf/core yesterday afternoon and could not find. However when this is already fixed, I will remove it from my patch list Thanks Thomas > > Link: http://lkml.kernel.org/n/tip-w4uuxbwcrf8cjjjbko3ujs95@git.kernel.org > > Signed-off-by: Jiri Olsa > > --- > > tools/perf/tests/attr/base-record | 2 +- > > tools/perf/tests/attr/test-record-group | 1 + > > tools/perf/tests/attr/test-record-group-sampling | 2 +- > > tools/perf/tests/attr/test-record-group1 | 1 + > > 4 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/tools/perf/tests/attr/base-record b/tools/perf/tests/attr/base-record > > index 31e0b1da830b..37940665f736 100644 > > --- a/tools/perf/tests/attr/base-record > > +++ b/tools/perf/tests/attr/base-record > > @@ -23,7 +23,7 @@ comm=1 > > freq=1 > > inherit_stat=0 > > enable_on_exec=1 > > -task=0 > > +task=1 > > watermark=0 > > precise_ip=0|1|2|3 > > mmap_data=0 > > diff --git a/tools/perf/tests/attr/test-record-group b/tools/perf/tests/attr/test-record-group > > index 6e7961f6f7a5..618ba1c17474 100644 > > --- a/tools/perf/tests/attr/test-record-group > > +++ b/tools/perf/tests/attr/test-record-group > > @@ -17,5 +17,6 @@ sample_type=327 > > read_format=4 > > mmap=0 > > comm=0 > > +task=0 > > enable_on_exec=0 > > disabled=0 > > diff --git a/tools/perf/tests/attr/test-record-group-sampling b/tools/perf/tests/attr/test-record-group-sampling > > index ef59afd6d635..f906b793196f 100644 > > --- a/tools/perf/tests/attr/test-record-group-sampling > > +++ b/tools/perf/tests/attr/test-record-group-sampling > > @@ -23,7 +23,7 @@ sample_type=343 > > > > # PERF_FORMAT_ID | PERF_FORMAT_GROUP > > read_format=12 > > - > > +task=0 > > mmap=0 > > comm=0 > > enable_on_exec=0 > > diff --git a/tools/perf/tests/attr/test-record-group1 b/tools/perf/tests/attr/test-record-group1 > > index 87a222d014d8..48e8bd12fe46 100644 > > --- a/tools/perf/tests/attr/test-record-group1 > > +++ b/tools/perf/tests/attr/test-record-group1 > > @@ -18,5 +18,6 @@ sample_type=327 > > read_format=4 > > mmap=0 > > comm=0 > > +task=0 > > enable_on_exec=0 > > disabled=0 > > -- > > 2.9.4 > > >