Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752247AbdHJID6 (ORCPT ); Thu, 10 Aug 2017 04:03:58 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:48414 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752095AbdHJIDw (ORCPT ); Thu, 10 Aug 2017 04:03:52 -0400 Message-ID: <1502352226.12382.1.camel@mtksdaap41> Subject: Re: [RESEND PATCH 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 From: Yingjoe Chen To: Jun Gao CC: Wolfram Sang , , , , , , "Matthias Brugger" , Date: Thu, 10 Aug 2017 16:03:46 +0800 In-Reply-To: <1502349760.930.66.camel@mhfsdcap03> References: <1502332061-25085-1-git-send-email-jun.gao@mediatek.com> <1502332061-25085-3-git-send-email-jun.gao@mediatek.com> <1502349760.930.66.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2295 Lines: 77 On Thu, 2017-08-10 at 15:22 +0800, Jun Gao wrote: > On Thu, 2017-08-10 at 10:27 +0800, Jun Gao wrote: > > From: Jun Gao > > > > Add i2c compatible for MT7622. Compare to MT8173 i2c controller, > > MT7622 limits message numbers to 255, and does not support 4GB > > DMA mode. > > > > These two resend patches only modify commit message. > Thanks! > > Jun Looks good to me, so for new version: Reviewed-by: Yingjoe Chen Joe.C > > > Signed-off-by: Jun Gao > > --- > > drivers/i2c/busses/i2c-mt65xx.c | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c > > index 9bedf0b..2c7f847 100644 > > --- a/drivers/i2c/busses/i2c-mt65xx.c > > +++ b/drivers/i2c/busses/i2c-mt65xx.c > > @@ -172,6 +172,14 @@ struct mtk_i2c { > > .max_comb_2nd_msg_len = 31, > > }; > > > > +static const struct i2c_adapter_quirks mt7622_i2c_quirks = { > > + .max_num_msgs = 255, > > + .max_write_len = 65535, > > + .max_read_len = 65535, > > + .max_comb_1st_msg_len = 65535, > > + .max_comb_2nd_msg_len = 65535, > > +}; > > + > > static const struct mtk_i2c_compatible mt6577_compat = { > > .quirks = &mt6577_i2c_quirks, > > .pmic_i2c = 0, > > @@ -190,6 +198,15 @@ struct mtk_i2c { > > .support_33bits = 0, > > }; > > > > +static const struct mtk_i2c_compatible mt7622_compat = { > > + .quirks = &mt7622_i2c_quirks, > > + .pmic_i2c = 0, > > + .dcm = 1, > > + .auto_restart = 1, > > + .aux_len_reg = 1, > > + .support_33bits = 0, > > +}; > > + > > static const struct mtk_i2c_compatible mt8173_compat = { > > .pmic_i2c = 0, > > .dcm = 1, > > @@ -201,6 +218,7 @@ struct mtk_i2c { > > static const struct of_device_id mtk_i2c_of_match[] = { > > { .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat }, > > { .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat }, > > + { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat }, > > { .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat }, > > {} > > }; > > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek