Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752275AbdHJILQ (ORCPT ); Thu, 10 Aug 2017 04:11:16 -0400 Received: from nbd.name ([46.4.11.11]:33428 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbdHJILO (ORCPT ); Thu, 10 Aug 2017 04:11:14 -0400 Subject: Re: [PATCH 0/4] net-next: dsa: fix flow dissection To: Eric Dumazet , David Miller Cc: andrew@lunn.ch, f.fainelli@gmail.com, muciri@openmesh.com, vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, shashidhar.lakkavalli@openmesh.com, linux-mediatek@lists.infradead.org References: <20170809124119.24320-1-john@phrozen.org> <20170809.225243.2204411285392662424.davem@davemloft.net> <1502347335.4936.2.camel@edumazet-glaptop3.roam.corp.google.com> From: John Crispin Message-ID: Date: Thu, 10 Aug 2017 10:10:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502347335.4936.2.camel@edumazet-glaptop3.roam.corp.google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1217 Lines: 34 On 10/08/17 08:42, Eric Dumazet wrote: > On Wed, 2017-08-09 at 22:52 -0700, David Miller wrote: >> From: John Crispin >> Date: Wed, 9 Aug 2017 14:41:15 +0200 >> >>> RPS and probably other kernel features are currently broken on some if not >>> all DSA devices. The root cause of this is that skb_hash will call the >>> flow_dissector. At this point the skb still contains the magic switch >>> header and the skb->protocol field is not set up to the correct 802.3 >>> value yet. By the time the tag specific code is called, removing the header >>> and properly setting the protocol an invalid hash is already set. In the >>> case of the mt7530 this will result in all flows always having the same >>> hash. >>> >>> Changes since RFC: >>> * use a callback instead of static values >>> * add cover letter >> Series applied, thanks. > Is this related ? > > net/core/flow_dissector.c: In function '__skb_flow_dissect': > net/core/flow_dissector.c:448:18: error: 'struct net_device' has no member named 'dsa_ptr' > ops = skb->dev->dsa_ptr->tag_ops; > ^ > make[3]: *** [net/core/flow_dissector.o] Error 1 > > Hi Eric, I have just sent the fix for this compile error John