Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751842AbdHJITI (ORCPT ); Thu, 10 Aug 2017 04:19:08 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:47450 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750735AbdHJITG (ORCPT ); Thu, 10 Aug 2017 04:19:06 -0400 Message-ID: <1502353140.17420.7.camel@mtksdaap41> Subject: Re: [RESEND PATCH 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding From: Honghui Zhang To: Jun Gao CC: Wolfram Sang , Matthias Brugger , , , , , , Date: Thu, 10 Aug 2017 16:19:00 +0800 In-Reply-To: <1502332061-25085-2-git-send-email-jun.gao@mediatek.com> References: <1502332061-25085-1-git-send-email-jun.gao@mediatek.com> <1502332061-25085-2-git-send-email-jun.gao@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1774 Lines: 38 On Thu, 2017-08-10 at 10:27 +0800, Jun Gao wrote: > From: Jun Gao > > Add MT7622 i2c binding to binding file. Compare to MT8173 i2c > controller, MT7622 limits message numbers to 255, and does not > support 4GB DMA mode. > > Signed-off-by: Jun Gao > --- > Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > index bd5a7be..ff9ac61 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices. > > Required properties: > - compatible: value should be either of the following. > - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701 > - "mediatek,mt6577-i2c": for i2c compatible with mt6577. > - "mediatek,mt6589-i2c": for i2c compatible with mt6589. > - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623. > - "mediatek,mt8173-i2c": for i2c compatible with mt8173. > + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701 > + "mediatek,mt6577-i2c": for Mediatek MT6577 > + "mediatek,mt6589-i2c": for Mediatek MT6589 Better not change those and just add compatible strings for mt7622. > + "mediatek,mt7622-i2c": for Mediatek MT7622 > + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623 > + "mediatek,mt8173-i2c": for Mediatek MT8173 > - reg: physical base address of the controller and dma base, length of memory > mapped region. > - interrupts: interrupt number to the cpu.