Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752015AbdHJKHN (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Aug 2017 06:07:13 -0400
Received: from mail-wm0-f44.google.com ([74.125.82.44]:32847 "EHLO
        mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751361AbdHJKHL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Aug 2017 06:07:11 -0400
Subject: Re: [PATCH v2 1/9] arm64: dts: hi3660: enable idle states
To: Guodong Xu <guodong.xu@linaro.org>, xuwei5@hisilicon.com,
        robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com,
        will.deacon@arm.com, keescook@chromium.org, anton@enomsg.org,
        ccross@android.com, tony.luck@intel.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, Leo Yan <leo.yan@linaro.org>,
        Kevin Wang <jean.wangtao@linaro.org>
References: <20170810022615.19204-1-guodong.xu@linaro.org>
 <20170810022615.19204-2-guodong.xu@linaro.org>
From: Daniel Lezcano <daniel.lezcano@linaro.org>
Message-ID: <b3d8f55b-3d70-9b3a-a4c6-474a933a13a9@linaro.org>
Date: Thu, 10 Aug 2017 12:07:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170810022615.19204-2-guodong.xu@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1263
Lines: 47


Hi Guodong, Leo,

there are several typos in the patch description. I *humbly* propose an
alternate description to make it a bit more English friendly.

"""

There are two clusters on the Hi3660, the first one is Cortex-A53 based
and the other one is Cortex-A73 based. These two clusters have different
idle states.

Thanks to Daniel Lezcano's recent changes, the generic ARM cpuidle
driver can now support several clusters with different idle states, thus
supporting the big.Little architecture.

In addition to the WFI idle state which is the default shallowest state
for all ARM cpus, the Hi3660 supports the following states:

 - CA53 CPUs:
	- CPU_SLEEP:       CPU power off state
	- CLUSTER_SLEEP_0: Cluster power off state

 - CA73 CPUs:
	- CPU_NAP:         CPU retention state
	- CPU_SLEEP:       CPU power off state
	- CLUSTER_SLEEP_1: Cluster power off state

This patch adds the idle states description for the Hi3660 to the device
tree.

"""


Other than that.

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>




-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog