Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752623AbdHJKhn (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Aug 2017 06:37:43 -0400
Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:44093 "EHLO
        metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751511AbdHJKhl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Aug 2017 06:37:41 -0400
Message-ID: <1502361454.10792.5.camel@pengutronix.de>
Subject: Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        linux-arm-kernel@lists.infradead.org
Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>,
        Jassi Brar <jaswinder.singh@linaro.org>, linux-kernel@vger.kernel.org
Date: Thu, 10 Aug 2017 12:37:34 +0200
In-Reply-To: <20170810072703.32433-3-suzuki.katsuhiro@socionext.com>
References: <20170810072703.32433-1-suzuki.katsuhiro@socionext.com>
         <20170810072703.32433-3-suzuki.katsuhiro@socionext.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17
X-SA-Exim-Mail-From: p.zabel@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1701
Lines: 50

Hi Katsuhiro,

On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:
> Add a reset line for analog signal amplifier core (ADAMV) on
> UniPhier LD11/LD20 SoCs.
> 
> > Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
> ---
>  drivers/reset/reset-uniphier.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
> index f60c137c17cb..cda4a78a58e2 100644
> --- a/drivers/reset/reset-uniphier.c
> +++ b/drivers/reset/reset-uniphier.c
> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data uniphier_pro4_peri_reset_data[] = {
> >  	UNIPHIER_RESET_END,
>  };
>  
> +/* Analog signal amplifiers reset data */
> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {
> > +	UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
> > +	UNIPHIER_RESET_END,
> +};
> +
>  /* core implementaton */
>  struct uniphier_reset_priv {
> >  	struct reset_controller_dev rcdev;
> @@ -415,6 +421,15 @@ static const struct of_device_id uniphier_reset_match[] = {
> >  		.compatible = "socionext,uniphier-ld20-peri-reset",
> >  		.data = uniphier_pro4_peri_reset_data,
> >  	},
> > +	/* Analog signal amplifiers reset */
> > +	{
> > +		.compatible = "socionext,uniphier-ld11-adamv-reset",
> > +		.data = uniphier_ld11_adamv_reset_data,
> > +	},
> > +	{
> > +		.compatible = "socionext,uniphier-ld20-adamv-reset",
> > +		.data = uniphier_ld11_adamv_reset_data,
> > +	},
> >  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, uniphier_reset_match);

Please add a patch to describe the new compatible values in
Documentation/devicetree/bindings/reset/uniphier-reset.txt.

regards
Philipp