Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752437AbdHJKhl (ORCPT ); Thu, 10 Aug 2017 06:37:41 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:41535 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbdHJKhj (ORCPT ); Thu, 10 Aug 2017 06:37:39 -0400 Date: Thu, 10 Aug 2017 12:37:32 +0200 From: Peter Zijlstra To: Vincent Guittot Cc: Joel Fernandes , linux-kernel , kernel-team@android.com, Juri Lelli , Brendan Jackman , Dietmar Eggeman , Ingo Molnar Subject: Re: [PATCH] sched/fair: Make PELT signal more accurate Message-ID: <20170810103732.u5q5xojsbhq2a4ij@hirez.programming.kicks-ass.net> References: <20170804154023.26874-1-joelaf@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 771 Lines: 15 On Thu, Aug 10, 2017 at 09:17:34AM +0200, Vincent Guittot wrote: > Ah! this is quite confusing and not obvious that the trace is not for > 1 signal but in fact 2 signals are interleaved and only 1 is displayed > and that we have to filter them > > So ok i can see that the trace with cfs_rq=1 is not updated. At the > opposite, we can see that the other trace (for the se i assume) is > updated normally whereas they are normally synced on the same clock So I'm still sitting on those patches that sync up the PELT window between group-cfs_rq and its corresponding group-se. I was hoping to get around to looking at all that again and adding Josef's last few patches and promoting the lot from /experimental to /core before going on holidays next week, but we'll see.