Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752275AbdHJKpj (ORCPT ); Thu, 10 Aug 2017 06:45:39 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3490 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752219AbdHJKph (ORCPT ); Thu, 10 Aug 2017 06:45:37 -0400 Subject: Re: [PATCH 1/1] f2fs: merge equivalent flags F2FS_GET_BLOCK_[READ|DIO] To: sunqiuyang , , , References: <1502270850-34212-1-git-send-email-sunqiuyang@huawei.com> From: Chao Yu Message-ID: <98fd4a5d-bec8-af99-14a0-93a006437b8f@huawei.com> Date: Thu, 10 Aug 2017 18:45:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502270850-34212-1-git-send-email-sunqiuyang@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.598C394F.0155,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 662bd470874f192b0834a36a11ddff33 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 561 Lines: 12 On 2017/8/9 17:27, sunqiuyang wrote: > From: Qiuyang Sun > > Currently, the two flags F2FS_GET_BLOCK_[READ|DIO] are totally equivalent > and can be used interchangably in all scenarios they are involved in. > Neither of the flags is referenced in f2fs_map_blocks(), making them both > the default case. To remove the ambiguity, this patch merges both flags > into F2FS_GET_BLOCK_DEFAULT, and introduces an enum for all distinct flags. > > Signed-off-by: Qiuyang Sun Reviewed-by: Chao Yu