Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751972AbdHJLES (ORCPT ); Thu, 10 Aug 2017 07:04:18 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:55273 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750868AbdHJLEQ (ORCPT ); Thu, 10 Aug 2017 07:04:16 -0400 From: Patrice CHOTARD To: Julia Lawall CC: "bhumirks@gmail.com" , "kernel-janitors@vger.kernel.org" , "Linus Walleij" , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 04/17] pinctrl: st: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures Thread-Topic: [PATCH 04/17] pinctrl: st: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures Thread-Index: AQHTEcP1ny2wj8oUxEaPwgIpefsPeqJ9S5eA Date: Thu, 10 Aug 2017 11:03:42 +0000 Message-ID: References: <1502359589-15970-1-git-send-email-Julia.Lawall@lip6.fr> <1502359589-15970-5-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1502359589-15970-5-git-send-email-Julia.Lawall@lip6.fr> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.47] Content-Type: text/plain; charset="utf-8" Content-ID: <49FCEF2A64D7D84D87CF8762A10911C2@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-10_03:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7AB4Ovh009337 Content-Length: 1713 Lines: 51 Hi Julia On 08/10/2017 12:06 PM, Julia Lawall wrote: > These structures are only stored in fields of a pinctrl_desc > structure (confops, pctlops, and pmxops) that are const. Make the > structures const as well. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/pinctrl/pinctrl-st.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > index 7ac8b1e..aed8006 100644 > --- a/drivers/pinctrl/pinctrl-st.c > +++ b/drivers/pinctrl/pinctrl-st.c > @@ -861,7 +861,7 @@ static void st_pctl_dt_free_map(struct pinctrl_dev *pctldev, > { > } > > -static struct pinctrl_ops st_pctlops = { > +static const struct pinctrl_ops st_pctlops = { > .get_groups_count = st_pctl_get_groups_count, > .get_group_pins = st_pctl_get_group_pins, > .get_group_name = st_pctl_get_group_name, > @@ -928,7 +928,7 @@ static int st_pmx_set_gpio_direction(struct pinctrl_dev *pctldev, > return 0; > } > > -static struct pinmux_ops st_pmxops = { > +static const struct pinmux_ops st_pmxops = { > .get_functions_count = st_pmx_get_funcs_count, > .get_function_name = st_pmx_get_fname, > .get_function_groups = st_pmx_get_groups, > @@ -1025,7 +1025,7 @@ static void st_pinconf_dbg_show(struct pinctrl_dev *pctldev, > ST_PINCONF_UNPACK_RT_DELAY(config)); > } > > -static struct pinconf_ops st_confops = { > +static const struct pinconf_ops st_confops = { > .pin_config_get = st_pinconf_get, > .pin_config_set = st_pinconf_set, > .pin_config_dbg_show = st_pinconf_dbg_show, > Acked-by: Patrice Chotard Thanks