Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752569AbdHJLK0 (ORCPT ); Thu, 10 Aug 2017 07:10:26 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:36618 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbdHJLKX (ORCPT ); Thu, 10 Aug 2017 07:10:23 -0400 Date: Thu, 10 Aug 2017 13:10:19 +0200 From: Ingo Molnar To: Byungchul Park Cc: peterz@infradead.org, tglx@linutronix.de, walken@google.com, boqun.feng@gmail.com, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org, npiggin@gmail.com, kernel-team@lge.com Subject: Re: [PATCH v8 00/14] lockdep: Implement crossrelease feature Message-ID: <20170810111019.n376bsm6h4de2jvi@gmail.com> References: <1502089981-21272-1-git-send-email-byungchul.park@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502089981-21272-1-git-send-email-byungchul.park@lge.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 602 Lines: 21 * Byungchul Park wrote: > Change from v7 > - rebase on latest tip/sched/core (Jul 26 2017) > - apply peterz's suggestions > - simplify code of crossrelease_{hist/soft/hard}_{start/end} > - exclude a patch avoiding redundant links > - exclude a patch already applied onto the base Ok, it's looking pretty good here now, there's one thing I'd like you to change, please remove all the new Kconfig dependencies: CONFIG_LOCKDEP_CROSSRELEASE=y CONFIG_LOCKDEP_COMPLETE=y and make it all part of PROVE_LOCKING, like most of the other lock debugging bits. Thanks, Ingo