Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752196AbdHJL2K (ORCPT ); Thu, 10 Aug 2017 07:28:10 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:47534 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751455AbdHJL2I (ORCPT ); Thu, 10 Aug 2017 07:28:08 -0400 Date: Thu, 10 Aug 2017 04:28:05 -0700 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , Christoph Hellwig , Huang Ying , Andrew Morton , Alexander Viro , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 09/49] block: comment on bio_iov_iter_get_pages() Message-ID: <20170810112805.GE20308@infradead.org> References: <20170808084548.18963-1-ming.lei@redhat.com> <20170808084548.18963-10-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170808084548.18963-10-ming.lei@redhat.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 397 Lines: 9 > + * The hacking way of using bvec table as page pointer array is safe > + * even after multipage bvec is introduced because that space can be > + * thought as unused by bio_add_page(). I'm not sure what value this comment adds. Note that once we have multi-page biovecs this could should change to take advantage of multipage biovecs, so adding a comment before that doesn't seem too helpful.