Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752231AbdHJL3I (ORCPT ); Thu, 10 Aug 2017 07:29:08 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:41550 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbdHJL3G (ORCPT ); Thu, 10 Aug 2017 07:29:06 -0400 Date: Thu, 10 Aug 2017 04:29:00 -0700 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , Christoph Hellwig , Huang Ying , Andrew Morton , Alexander Viro , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Mike Snitzer Subject: Re: [PATCH v3 10/49] dm: limit the max bio size as BIO_MAX_PAGES * PAGE_SIZE Message-ID: <20170810112900.GF20308@infradead.org> References: <20170808084548.18963-1-ming.lei@redhat.com> <20170808084548.18963-11-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170808084548.18963-11-ming.lei@redhat.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 254 Lines: 9 > + ti->max_io_len = min_t(uint32_t, len, > + (BIO_MAX_PAGES * PAGE_SIZE)); No need for the inner braces. Also all of the above fits nicely onto a single < 80 char line. Otherwise this looks fine: Reviewed-by: Christoph Hellwig