Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752490AbdHJMAh (ORCPT ); Thu, 10 Aug 2017 08:00:37 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:41901 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752012AbdHJMAf (ORCPT ); Thu, 10 Aug 2017 08:00:35 -0400 Date: Thu, 10 Aug 2017 05:00:29 -0700 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , Christoph Hellwig , Huang Ying , Andrew Morton , Alexander Viro , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 18/49] block: introduce multipage/single page bvec helpers Message-ID: <20170810120029.GA14607@infradead.org> References: <20170808084548.18963-1-ming.lei@redhat.com> <20170808084548.18963-19-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170808084548.18963-19-ming.lei@redhat.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 449 Lines: 9 Please skip adding the _sp names for the single page ones - those are the only used to implement the non postfixed ones anyway. The _mp ones should have bio_iter_segment_* names instead. And while you're at it - I think this code would massively benefit from turning it into inline functions in a prep step before doing these changes, including passing the iter by reference for all these functions instead of the odd by value calling convention.