Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752537AbdHJMBx (ORCPT ); Thu, 10 Aug 2017 08:01:53 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:33733 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752208AbdHJMBv (ORCPT ); Thu, 10 Aug 2017 08:01:51 -0400 Date: Thu, 10 Aug 2017 05:01:46 -0700 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , Christoph Hellwig , Huang Ying , Andrew Morton , Alexander Viro , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 19/49] block: implement sp version of bvec iterator helpers Message-ID: <20170810120146.GB14607@infradead.org> References: <20170808084548.18963-1-ming.lei@redhat.com> <20170808084548.18963-20-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170808084548.18963-20-ming.lei@redhat.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 494 Lines: 13 On Tue, Aug 08, 2017 at 04:45:18PM +0800, Ming Lei wrote: > This patch implements singlepage version of the following > 3 helpers: > - bvec_iter_offset_sp() > - bvec_iter_len_sp() > - bvec_iter_page_sp() > > So that one multipage bvec can be splited to singlepage > bvec, and make users of current bvec iterator happy. Please merge this into the previous patch, and keep the existing non postfixed names for the single page version, and use bvec_iter_segment_* for the multipage versions.