Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752389AbdHJMjV (ORCPT ); Thu, 10 Aug 2017 08:39:21 -0400 Received: from guitar.tcltek.co.il ([192.115.133.116]:46158 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752060AbdHJMjU (ORCPT ); Thu, 10 Aug 2017 08:39:20 -0400 Date: Thu, 10 Aug 2017 15:39:15 +0300 From: Baruch Siach To: Julia Lawall Cc: Linus Walleij , bhumirks@gmail.com, kernel-janitors@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/17] pinctrl: digicolor: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures Message-ID: <20170810123915.3mqvg4f3qqx4e45f@tarshish> References: <1502359589-15970-1-git-send-email-Julia.Lawall@lip6.fr> <1502359589-15970-8-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502359589-15970-8-git-send-email-Julia.Lawall@lip6.fr> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1604 Lines: 47 Hi Julia, On Thu, Aug 10, 2017 at 12:06:19PM +0200, Julia Lawall wrote: > These structures are only stored in fields of a pinctrl_desc > structure (pctlops and pmxops) that are const. Make the > structures const as well. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Acked-by: Baruch Siach Thanks, baruch > --- > drivers/pinctrl/pinctrl-digicolor.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c > index 639a57e..ce269ce 100644 > --- a/drivers/pinctrl/pinctrl-digicolor.c > +++ b/drivers/pinctrl/pinctrl-digicolor.c > @@ -79,7 +79,7 @@ static int dc_get_group_pins(struct pinctrl_dev *pctldev, unsigned selector, > return 0; > } > > -static struct pinctrl_ops dc_pinctrl_ops = { > +static const struct pinctrl_ops dc_pinctrl_ops = { > .get_groups_count = dc_get_groups_count, > .get_group_name = dc_get_group_name, > .get_group_pins = dc_get_group_pins, > @@ -161,7 +161,7 @@ static int dc_pmx_request_gpio(struct pinctrl_dev *pcdev, > return 0; > } > > -static struct pinmux_ops dc_pmxops = { > +static const struct pinmux_ops dc_pmxops = { > .get_functions_count = dc_get_functions_count, > .get_function_name = dc_get_fname, > .get_function_groups = dc_get_groups, -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -