Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752721AbdHJOKY (ORCPT ); Thu, 10 Aug 2017 10:10:24 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:59698 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914AbdHJOKX (ORCPT ); Thu, 10 Aug 2017 10:10:23 -0400 Date: Thu, 10 Aug 2017 16:10:18 +0200 From: Andrew Lunn To: Vitaly Kuznetsov Cc: ???????????? , network dev , Linux Kernel Mailing List , "David S. Miller" , Eric Dumazet , Stephen Hemminger Subject: Re: [PATCH RFC net-next] net: Allow name change of IFF_UP interfaces Message-ID: <20170810141018.GC24790@lunn.ch> References: <20170809104202.30959-1-vkuznets@redhat.com> <87efskye74.fsf@vitty.brq.redhat.com> <20170809161027.GA28694@lunn.ch> <871sojyfv0.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871sojyfv0.fsf@vitty.brq.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 934 Lines: 26 > >> Can you think of any particular real world scenarios which are broken by > >> the change? > > > > How about: > > > > man 8 dhclient-script > > > > The interface name is passed in $interface to the scripts. Do we get > > the old name or the new name? I suspect scripts are going to break if > > they are given the old name, which no longer exists. > > Yes but why would anyone change interface name while dhclient-script is > running? Things will also go wrong if you try bringing interface down > during the run or do some other configuration, right? dhclient already handles the interface going down. sendto/recvfrom fails and returns an error code. As far as i remember, dhclient then exits. > Running multiple configuration tools at the same moment is a bad > idea, you never know what you're gonna end up with. It could be argued that configuring an interface vs renaming an interface are at different levels. Andrew