Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752524AbdHJPUw (ORCPT ); Thu, 10 Aug 2017 11:20:52 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45762 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914AbdHJPUv (ORCPT ); Thu, 10 Aug 2017 11:20:51 -0400 Date: Thu, 10 Aug 2017 08:20:49 -0700 From: Greg Kroah-Hartman To: Pan Bian Cc: Dmitry Torokhov , Guenter Roeck , Wei-Ning Huang , Christophe JAILLET , Wei Yongjun , linux-kernel@vger.kernel.org Subject: Re: [V2] firmware: vpd: use memunmap instead of iounmap Message-ID: <20170810152049.GB16915@kroah.com> References: <1502276507-11921-1-git-send-email-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502276507-11921-1-git-send-email-bianpan2016@163.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 469 Lines: 17 On Wed, Aug 09, 2017 at 07:01:47PM +0800, Pan Bian wrote: > In functions vpd_sections_init() and vpd_section_init(), iounmap() is > used to unmap memory. However, in these cases, memunmap() should be > used. > > Signed-off-by: Pan Bian > --- > drivers/firmware/google/vpd.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) What changed from v1? Always put that below the --- line. Please fix and do a v3. thanks, greg k-h