Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752460AbdHJPZb (ORCPT ); Thu, 10 Aug 2017 11:25:31 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:36978 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751975AbdHJPZa (ORCPT ); Thu, 10 Aug 2017 11:25:30 -0400 Date: Thu, 10 Aug 2017 16:24:37 +0100 From: Mark Brown To: srinivas.kandagatla@linaro.org Cc: Banajit Goswami , alsa-devel@alsa-project.org, damien.riegel@savoirfairelinux.com, Jaroslav Kysela , Takashi Iwai , Patrick Lai , linux-kernel@vger.kernel.org Message-ID: <20170810152437.ezfhi7cukutyabmt@sirena.org.uk> References: <20170809164927.19663-1-srinivas.kandagatla@linaro.org> <20170809164927.19663-3-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="z6ujwgqd7l5jrigt" Content-Disposition: inline In-Reply-To: <20170809164927.19663-3-srinivas.kandagatla@linaro.org> X-Cookie: Do you like "TENDER VITTLES"? User-Agent: NeoMutt/20170609 (1.8.3) X-SA-Exim-Connect-IP: 86.142.17.160 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3 2/5] ASoC: codecs: msm8916-wcd-analog: get micbias voltage from dt X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1069 Lines: 33 --z6ujwgqd7l5jrigt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 09, 2017 at 06:49:24PM +0200, srinivas.kandagatla@linaro.org wrote: > - snd_soc_write(codec, CDC_A_MICB_1_VAL, MICB_1_VAL_MICB_OUT_VAL_V2P70V); > - /* > - * Special headset needs MICBIAS as 2.7V so wait for > - * 50 msec for the MICBIAS to reach 2.7 volts. > - */ > - msleep(50); > + if (wcd->micbias_mv) We seem to have just completely lost this ramp time handling? --z6ujwgqd7l5jrigt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmMerQACgkQJNaLcl1U h9ANWQf/eOKmZtDl7Ev0tgUwV5RB3Rr6CkkerQlA6J0agUEYjoUim6b0nL+xQSKf IW2sncqldb51+d3owLVFbkiUc2U7incAShScipA0JKC0PNQ8pZfUlA7nnlnkYIp7 nmXy6+fS343zJ80kKpPflCdGBqXOKH6LgTgzavyBfbgaYLOAIAESimIwPaJZTc51 zREtM4+CpyzbLIoxRWR4npLoMXLiZREsxESrrFh1RQrkTMUrvaULlQ5kvbbMWb/G 8pey4nAka3rbsRPBAwvml2tSux6mKxD/nKOpSg70pD+zvpqAIPHJiz2PzEczR30/ iFCL8a3tTyDIHnNhcfujbNpoDeSBCg== =uTOH -----END PGP SIGNATURE----- --z6ujwgqd7l5jrigt--