Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753017AbdHJQQz (ORCPT ); Thu, 10 Aug 2017 12:16:55 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:60792 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982AbdHJQQy (ORCPT ); Thu, 10 Aug 2017 12:16:54 -0400 Date: Thu, 10 Aug 2017 09:16:53 -0700 (PDT) Message-Id: <20170810.091653.1966810110752157678.davem@davemloft.net> To: john@phrozen.org Cc: jiri@mellanox.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: core: fix compile error inside flow_dissector due to new dsa callback From: David Miller In-Reply-To: <20170810080903.32231-1-john@phrozen.org> References: <20170810080903.32231-1-john@phrozen.org> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 10 Aug 2017 09:16:53 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 543 Lines: 16 From: John Crispin Date: Thu, 10 Aug 2017 10:09:03 +0200 > The following error was introduced by > commit 43e665287f93 ("net-next: dsa: fix flow dissection") > due to a missing #if guard > > net/core/flow_dissector.c: In function '__skb_flow_dissect': > net/core/flow_dissector.c:448:18: error: 'struct net_device' has no member named 'dsa_ptr' > ops = skb->dev->dsa_ptr->tag_ops; > ^ > make[3]: *** [net/core/flow_dissector.o] Error 1 > > Signed-off-by: John Crispin Applied, thanks.