Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753210AbdHJQRx (ORCPT ); Thu, 10 Aug 2017 12:17:53 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59752 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752751AbdHJQRv (ORCPT ); Thu, 10 Aug 2017 12:17:51 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DBD46600E2 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH] dmaengine: qcom_hidma: avoid freeing an uninitialized pointer To: Anton Vasilyev , Andy Gross Cc: David Brown , Dan Williams , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org References: <1502380465-13434-1-git-send-email-vasilyev@ispras.ru> From: Sinan Kaya Message-ID: Date: Thu, 10 Aug 2017 12:17:47 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502380465-13434-1-git-send-email-vasilyev@ispras.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1291 Lines: 35 On 8/10/2017 11:54 AM, Anton Vasilyev wrote: > If device_node np doesn't contain child or first child doesn't have > property "reg" then hidma_mgmt_of_populate_channels() perfoms > deallocation on uninitialized local variable res. > > The patch adds res initialization by NULL. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Anton Vasilyev > --- > drivers/dma/qcom/hidma_mgmt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c > index 5a0991b..89e36e3 100644 > --- a/drivers/dma/qcom/hidma_mgmt.c > +++ b/drivers/dma/qcom/hidma_mgmt.c > @@ -354,7 +354,7 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np) > struct platform_device_info pdevinfo; > struct of_phandle_args out_irq; > struct device_node *child; > - struct resource *res; > + struct resource *res = NULL; > const __be32 *cell; > int ret = 0, size, i, num; > u64 addr, addr_size; > Reviewed-by: Sinan Kaya -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.