Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752980AbdHJQXB (ORCPT ); Thu, 10 Aug 2017 12:23:01 -0400 Received: from mail-io0-f177.google.com ([209.85.223.177]:33674 "EHLO mail-io0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168AbdHJQXA (ORCPT ); Thu, 10 Aug 2017 12:23:00 -0400 Date: Thu, 10 Aug 2017 10:22:56 -0600 From: Tycho Andersen To: Konrad Rzeszutek Wilk Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-hardening@lists.openwall.com, Marco Benatto , Juerg Haefliger , Juerg Haefliger Subject: Re: [PATCH v5 03/10] swiotlb: Map the buffer if it was unmapped by XPFO Message-ID: <20170810162256.ah4yre6xjbfd5oi3@smitten> References: <20170809200755.11234-1-tycho@docker.com> <20170809200755.11234-4-tycho@docker.com> <20170810130104.GB2413@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170810130104.GB2413@localhost.localdomain> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 589 Lines: 17 On Thu, Aug 10, 2017 at 09:01:06AM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Aug 09, 2017 at 02:07:48PM -0600, Tycho Andersen wrote: > > +inline bool xpfo_page_is_unmapped(struct page *page) > > +{ > > + if (!static_branch_unlikely(&xpfo_inited)) > > + return false; > > + > > + return test_bit(XPFO_PAGE_UNMAPPED, &lookup_xpfo(page)->flags); > > +} > > +EXPORT_SYMBOL(xpfo_page_is_unmapped); > > How can it be inline and 'EXPORT_SYMBOL' ? And why make it inline? It > surely does not need to be access that often? Good point. I'll drop inline from the next version, thanks! Tycho