Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752895AbdHJQ0G (ORCPT ); Thu, 10 Aug 2017 12:26:06 -0400 Received: from mga04.intel.com ([192.55.52.120]:60960 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752243AbdHJQ0F (ORCPT ); Thu, 10 Aug 2017 12:26:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,353,1498546800"; d="scan'208";a="298538105" Date: Thu, 10 Aug 2017 12:32:50 -0400 From: Keith Busch To: Johannes Thumshirn Cc: Christoph Hellwig , Sagi Grimberg , Linux Kernel Mailinglist , Linux NVMe Mailinglist , Jens Axboe , Martin Peres Subject: Re: [PATCH v2] nvme: Fix nvme reset command timeout handling Message-ID: <20170810163250.GA14634@localhost.localdomain> References: <20170810092331.11159-1-jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170810092331.11159-1-jthumshirn@suse.de> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 816 Lines: 19 On Thu, Aug 10, 2017 at 11:23:31AM +0200, Johannes Thumshirn wrote: > From: Keith Busch > > We need to return an error if a timeout occurs on any NVMe command during > initialization. Without this, the nvme reset work will be stuck. A timeout > will have a negative error code, meaning we need to stop initializing > the controller. All postitive returns mean the controller is still usable. > > bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196325 > > Signed-off-by: Keith Busch > Cc: Martin Peres > [jth consolidated cleanup path ] > Signed-off-by: Johannes Thumshirn This looks great, thanks for fixing that up! I noticed the HMB setting in pci.c can also potentially timeout. We can deal with that later.