Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752895AbdHJRAW (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Aug 2017 13:00:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60584 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751982AbdHJRAU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Aug 2017 13:00:20 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 64048C0079B3
Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=vkuznets@redhat.com
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: x86@kernel.org, devel@linuxdriverproject.org,
        linux-kernel@vger.kernel.org, "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Steven Rostedt <rostedt@goodmis.org>,
        Jork Loeser <Jork.Loeser@microsoft.com>,
        Simon Xiao <sixiao@microsoft.com>, Andy Lutomirski <luto@kernel.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v10 0/9] Hyper-V: paravirtualized remote TLB flushing and hypercall improvements
References: <20170802160921.21791-1-vkuznets@redhat.com>
        <20170810160308.az2h66sfc62zyyjr@gmail.com>
Date: Thu, 10 Aug 2017 19:00:12 +0200
In-Reply-To: <20170810160308.az2h66sfc62zyyjr@gmail.com> (Ingo Molnar's
        message of "Thu, 10 Aug 2017 18:03:08 +0200")
Message-ID: <874ltfs6hv.fsf@vitty.brq.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 10 Aug 2017 17:00:20 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1215
Lines: 40

Ingo Molnar <mingo@kernel.org> writes:

> I'm getting this build failure with this series:
>
> arch/x86/hyperv/mmu.c: In function ‘hyperv_setup_mmu_ops’:
> arch/x86/hyperv/mmu.c:256:3: error: ‘pv_mmu_ops’ undeclared (first use in this 
> function)
>    pv_mmu_ops.flush_tlb_others = hyperv_flush_tlb_others;
>    ^
>
> with the attached (rand-)config.
>

> # CONFIG_PARAVIRT is not set

Ouch, this is definitely required for the new feature. Sorry :-(

I think the best way to handle this (and having in mind upcoming PV
spinlocks for Hyper-V) is something like

diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig
index c29cd5387a35..50b89ea0e60f 100644
--- a/drivers/hv/Kconfig
+++ b/drivers/hv/Kconfig
@@ -3,6 +3,7 @@ menu "Microsoft Hyper-V guest support"
 config HYPERV
        tristate "Microsoft Hyper-V client drivers"
        depends on X86 && ACPI && PCI && X86_LOCAL_APIC && HYPERVISOR_GUEST
+       select PARAVIRT
        help
          Select this option to run Linux as a Hyper-V client operating
          system.

added to PATCH7 of the series. In case nobody objects, would you like me
to resend the patch or do the whole v11 submission?

Thanks and sorry for the breakage,

-- 
  Vitaly