Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753188AbdHJR67 (ORCPT ); Thu, 10 Aug 2017 13:58:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:53228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772AbdHJR66 (ORCPT ); Thu, 10 Aug 2017 13:58:58 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C53BD22B65 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Thu, 10 Aug 2017 14:58:45 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Milian Wolff , Jin Yao , "linux-kernel@vger.kernel.org" , linux-perf-users , Arnaldo Carvalho de Melo , David Ahern , Peter Zijlstra , kernel-team@lge.com Subject: Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes Message-ID: <20170810175845.GB3900@kernel.org> References: <20170806212446.24925-1-milian.wolff@kdab.com> <20170806212446.24925-12-milian.wolff@kdab.com> <20170810021325.GA1797@sejong> <4512331.57hptoN48J@agathebauer> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 695 Lines: 16 Em Thu, Aug 10, 2017 at 11:56:24PM +0900, Namhyung Kim escreveu: > On Thu, Aug 10, 2017 at 8:51 PM, Milian Wolff wrote: > > On Donnerstag, 10. August 2017 04:13:25 CEST Namhyung Kim wrote: > >> Agreed. Also I guess no need to unwind anymore to get a srcfile for > >> an entry with your change. > > Does this mean I should respin the patch series with the above changes > > integrated? Or can we get this in first and then continue with the cleanup as > > described above later on? > Nop, it can be done later IMHO. I will try to review the code next week. Ok, I'm preparing a new batch to send to Ingo, will wait a bit more for your review, ok, Millian? - Arnaldo