Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752843AbdHJSYJ (ORCPT ); Thu, 10 Aug 2017 14:24:09 -0400 Received: from merlin.infradead.org ([205.233.59.134]:42674 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752504AbdHJSYI (ORCPT ); Thu, 10 Aug 2017 14:24:08 -0400 Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM To: Thomas Meyer , paul.burton@imgtec.com, linux-kernel@vger.kernel.org References: <20170810085353.27729-1-thomas@m3y3r.de> From: Randy Dunlap Message-ID: Date: Thu, 10 Aug 2017 11:24:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170810085353.27729-1-thomas@m3y3r.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 856 Lines: 31 On 08/10/2017 01:53 AM, Thomas Meyer wrote: > This avoids the MODPOST error: > ERROR: "devm_ioremap_resource" [drivers/auxdisplay/img-ascii-lcd.ko] undefined! > > Signed-off-by: Thomas Meyer > --- > drivers/auxdisplay/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig > index 9ae6681c90ad..9088c66e4c08 100644 > --- a/drivers/auxdisplay/Kconfig > +++ b/drivers/auxdisplay/Kconfig > @@ -135,6 +135,7 @@ config CFAG12864B_RATE > > config IMG_ASCII_LCD > tristate "Imagination Technologies ASCII LCD Display" > + depends on HAS_IOMEM > default y if MIPS_MALTA || MIPS_SEAD3 > select SYSCON > help > I posted the same patch on 2017-JAN-01, so I agree with it. https://lkml.org/lkml/2017/1/1/87 Acked-by: Randy Dunlap -- ~Randy