Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753303AbdHJUef (ORCPT ); Thu, 10 Aug 2017 16:34:35 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:35455 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752942AbdHJUee (ORCPT ); Thu, 10 Aug 2017 16:34:34 -0400 Date: Thu, 10 Aug 2017 22:34:30 +0200 From: Alexandre Belloni To: Aleksandar Markovic Cc: linux-mips@linux-mips.org, Miodrag Dinic , Goran Ferenc , Aleksandar Markovic , Alessandro Zummo , Bo Hu , "David S. Miller" , Douglas Leung , Greg Kroah-Hartman , James Hogan , Jin Qian , linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, Mauro Carvalho Chehab , Paul Burton , Petar Jovanovic , Raghu Gandham Subject: Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver Message-ID: <20170810203430.zgtxvi7uaqmg4dzr@piout.net> References: <1500656111-9520-1-git-send-email-aleksandar.markovic@rt-rk.com> <1500656111-9520-3-git-send-email-aleksandar.markovic@rt-rk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500656111-9520-3-git-send-email-aleksandar.markovic@rt-rk.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1058 Lines: 33 Hi, On 21/07/2017 at 18:53:31 +0200, Aleksandar Markovic wrote: > From: Miodrag Dinic > > Add device driver for a virtual Goldfish RTC clock. > > The driver can be built only if CONFIG_MIPS and CONFIG_GOLDFISH are > set. The compatible string used by OS for binding the driver is > defined as "google,goldfish-rtc". > > Signed-off-by: Miodrag Dinic > Signed-off-by: Goran Ferenc > Signed-off-by: Aleksandar Markovic > --- > MAINTAINERS | 1 + > drivers/rtc/Kconfig | 8 ++ > drivers/rtc/Makefile | 1 + > drivers/rtc/rtc-goldfish.c | 233 +++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 243 insertions(+) > create mode 100644 drivers/rtc/rtc-goldfish.c > Do you mind fixing the remaining checkpatch --strict issues, the two kbuild errors and the warning reported by Julia? Thanks! -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com