Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753378AbdHJVcY (ORCPT ); Thu, 10 Aug 2017 17:32:24 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3503 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752440AbdHJVcX (ORCPT ); Thu, 10 Aug 2017 17:32:23 -0400 Subject: Re: [PATCH] acpi: apei: fix the wrongly parse generic error status block To: "Baicar, Tyler" , , , , References: <1502388412-20273-1-git-send-email-gengdongjiu@huawei.com> <9ea70eed-f743-0c8b-2a70-27ce4c0d8705@codeaurora.org> From: gengdongjiu Message-ID: Date: Fri, 11 Aug 2017 05:31:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <9ea70eed-f743-0c8b-2a70-27ce4c0d8705@codeaurora.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.68.147] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.598CD0DC.0149,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 3c7c4dcb5585e849ee787386e183364e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1825 Lines: 44 Hello, sorry, I do not see that. Just know I have reviewed your modification, may be my change can be simpleness and reserve the macro of apei_estatus_for_each_section can be used by other place to avoid duplicated code, such as prints the estatus blocks. On 2017/8/11 1:48, Baicar, Tyler wrote: > Hello, > > I have already posted a patch fixing this. Please see: > > https://lkml.org/lkml/2017/8/3/824 > > This makes the loop identical to the CPER code which prints the estatus blocks to the kernel logs. > > Thanks, > > Tyler > > > On 8/10/2017 12:06 PM, Dongjiu Geng wrote: >> The revision 0x300 generic error data entry is different with the old >> version. when ghes_do_proc traverses to get the data entry, it does not >> consider this difference. so when error status block has revision 0x300 >> data entry, it will have issue. >> >> Signed-off-by: Dongjiu Geng >> --- >> drivers/acpi/apei/apei-internal.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/acpi/apei/apei-internal.h b/drivers/acpi/apei/apei-internal.h >> index 6e9f14c0a71b..6491f1c4a96e 100644 >> --- a/drivers/acpi/apei/apei-internal.h >> +++ b/drivers/acpi/apei/apei-internal.h >> @@ -122,8 +122,8 @@ struct dentry *apei_get_debugfs_dir(void); >> #define apei_estatus_for_each_section(estatus, section) \ >> for (section = (struct acpi_hest_generic_data *)(estatus + 1); \ >> - (void *)section - (void *)estatus < estatus->data_length; \ >> - section = (void *)(section+1) + section->error_data_length) >> + (void *)section - (void *)(estatus + 1) < estatus->data_length; \ >> + section = acpi_hest_get_next(section)) >> static inline u32 cper_estatus_len(struct acpi_hest_generic_status *estatus) >> { >