Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753336AbdHJWHC (ORCPT ); Thu, 10 Aug 2017 18:07:02 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3059 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbdHJWHA (ORCPT ); Thu, 10 Aug 2017 18:07:00 -0400 Subject: Re: [PATCH] acpi: apei: fix GHES estatus iteration To: "Rafael J. Wysocki" , Will Deacon References: <1501795945-5331-1-git-send-email-tbaicar@codeaurora.org> <20170808163219.GB2163@arm.com> <1971058.u9kdacGNiq@aspire.rjw.lan> CC: Tyler Baicar , , , , , , , , , , From: gengdongjiu Message-ID: <5591b641-6eb0-0cb6-e74d-7e55cad5ee33@huawei.com> Date: Fri, 11 Aug 2017 06:04:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1971058.u9kdacGNiq@aspire.rjw.lan> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.68.147] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.598CD8EB.01D0,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 1fecd844f8fef747a07196d05210fb3e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1664 Lines: 45 On 2017/8/9 8:52, Rafael J. Wysocki wrote: > On Tuesday, August 8, 2017 6:32:20 PM CEST Will Deacon wrote: >> On Thu, Aug 03, 2017 at 03:32:25PM -0600, Tyler Baicar wrote: >>> Currently iterating through the GHES estatus blocks does not >>> take into account the new generic data v3 structure size. This >>> can result in garbage non-standard trace events to be triggered >>> since the loop will not properly iterate through the estatus >>> blocks and not properly terminate. >>> >>> Update the GHES estatus iteration to properly increment through >>> the estatus blocks similar to how the CPER estatus printing >>> iterates through them. >>> >>> Fixes: bbcc2e7b642e ("ras: acpi/apei: cper: add support for generic data v3 structure") I do not think it has relationship with this "bbcc2e7b642e", the root cause is that it does not consider the acpi_hest_generic_data_v300, this code exists long long time ago. so please also review this patch: https://lkml.org/lkml/2017/8/10/747 previously I do not see Tyler's this modification, just know see it. >>> Signed-off-by: Tyler Baicar >>> Tested-by: Austin Christ >>> --- >>> drivers/acpi/apei/apei-internal.h | 5 ----- >>> drivers/acpi/apei/ghes.c | 8 +++++++- >>> 2 files changed, 7 insertions(+), 6 deletions(-) >> >> Whilst much of the initial code here went through the arm64 tree in the >> previous merge window, I'm assuming that Boris will take this fix via his >> tree (likewise for "[PATCH V2] acpi: apei: clear error status before >> acknowledging the error"). > > Actually I will if Boris ACKs these. > > Thanks, > Rafael > > > . >