Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752175AbdHJXp5 (ORCPT ); Thu, 10 Aug 2017 19:45:57 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:56991 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751550AbdHJXpw (ORCPT ); Thu, 10 Aug 2017 19:45:52 -0400 From: Mauro Carvalho Chehab To: Linux Doc Mailing List Cc: Mauro Carvalho Chehab , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, Jonathan Corbet , Hans Verkuil , Stanimir Varbanov , Laurent Pinchart , Sakari Ailus , Hans Verkuil , Kieran Bingham , Tomasz Figa Subject: [PATCH 0/3] v4l2-compat-ioctl32.c: better detect pointer controls Date: Thu, 10 Aug 2017 20:45:10 -0300 Message-Id: X-Mailer: git-send-email 2.13.3 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 965 Lines: 23 In the past, only string controls were pointers. That changed when compounded types got added, but the compat32 code was not updated. We could just add those controls there, but maintaining it is flaw, as we often forget about the compat code. So, instead, rely on the control type, as this is always updated when new controls are added. As both v4l2-ctrl and compat32 code are at videodev.ko module, we can move the ctrl_is_pointer() helper function to v4l2-ctrl.c. Mauro Carvalho Chehab (3): media: v4l2-ctrls.h: better document the arguments for v4l2_ctrl_fill media: v4l2-ctrls: prepare the function to be used by compat32 code media: compat32: reimplement ctrl_is_pointer() drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 18 +--------- drivers/media/v4l2-core/v4l2-ctrls.c | 49 +++++++++++++++++++++++++-- include/media/v4l2-ctrls.h | 28 ++++++++++----- 3 files changed, 67 insertions(+), 28 deletions(-) -- 2.13.3